should i have done this?

[HPG ADMIN]

That's the thing - you dont want callers here. You are letting them draw out on you. And going all in isn't nessesarily giving away your made flush. Most players with a made flush will bet medium. By betting strong you make it look like you have a strong hand like pocket Kings and you are trying to protect it. You need to bet huge and then the other player has 2 choices:

They can fold and have a 0% chance of winning the hand or
Call all-in and have a 33% chance (or whatever the flush % is).

By letting them draw cheaply you are letting them hit their hand while you have a hand that is hard to lay down.